feat: Switch notification refresh from schedule to inactivity timer #2168
+314
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notification refresh system previously used a fixed 60-second interval that could interrupt users while they were actively managing notifications (e.g., marking them as read). This PR changes the behavior to only refresh notifications after 60 seconds of user inactivity.
Changes Made
useInactivityTimer
hook: Tracks user activity across the app and triggers callbacks only after periods of inactivityuseInterval
touseInactivityTimer
for notification fetching inApp.tsx
Benefits
Implementation Details
The new
useInactivityTimer
hook:mousedown
,mousemove
,keypress
,scroll
,touchstart
,click
Testing
Added comprehensive tests covering:
All existing tests continue to pass, ensuring no breaking changes.
Fixes #1437.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/gitify-app/notifications-test/issues/comments/302888448
/usr/local/bin/node /home/REDACTED/work/gitify/gitify/node_modules/jest-worker/build/processChild.js
(http block)https://api.github.com/user
/usr/local/bin/node /home/REDACTED/work/gitify/gitify/node_modules/jest-worker/build/processChild.js
(http block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.