Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add work item support to WebHookManager #1215

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

ParkerMc
Copy link
Contributor

@ParkerMc ParkerMc commented Dec 20, 2024

It appears that the WorkItemEvent has been implemented but not added to the WebHookManager. With gitlab 17.7 new issues and epics use an object_kind of work_item when webhooks are sent.

@ParkerMc ParkerMc marked this pull request as ready for review December 20, 2024 15:35
Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not really using the WebHookManager myself so I missed it when implementing the WorkItemEvent.

I think this addition makes sense, thank you for this pull-request.

@jmini jmini merged commit 28f43e5 into gitlab4j:main Dec 24, 2024
3 checks passed
@jmini
Copy link
Collaborator

jmini commented Dec 24, 2024

🎉 merged!

Maybe WorkItemEvent also needs to be updated after the GitLab update 17.7 (I didn't tested yet with this version)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants