Skip to content

Remove cache folder in predeploy script, and refine Markdown formatting #22

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

coder054
Copy link

No description provided.

@dsyadav50
Copy link

some changes

Copy link

@sanketBarapatre sanketBarapatre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are these changes?

@lukem512
Copy link

The remove cache steps are nice and they helped to resolve a build issue where I bailed out (Ctrl + c) halfway through. It seems odd to bundle that with README updates, however.

@gitname
Copy link
Owner

gitname commented Dec 29, 2019

Hello @coder054, thank you for submitting a pull request. I am not familiar with that node_modules/gh-pages/.cache folder and have not noticed a need to interact with it directly (e.g. deleting its contents or performing any other action on it).

I want to avoid having unnecessary steps in the process. To that end, I want to better understand the step you are proposing (i.e. the step of deleting the aforementioned folder). In what situation does that step provide a benefit? How can I get a repo into a state in which I can witness the effect of the step (i.e. so I can manually test the step)?

@lukem512 suggested killing the build process part way through would put a repo into such a state.

The remove cache steps are nice and they helped to resolve a build issue where I bailed out (Ctrl + c) halfway through...

Maybe that's the same situation you had in mind.

On a side note, I also agree with @lukem512's feedback that:

It seems odd to bundle that with README updates

I know sometimes code editors automatically reformat entire files as soon as the file has been saved. I suspect that is what happened here.

@gitname gitname changed the title Add remove cache step in predeploy Remove cache in predeploy script, and refine Markdown formatting Dec 29, 2019
@gitname gitname changed the title Remove cache in predeploy script, and refine Markdown formatting Remove cache folder in predeploy script, and refine Markdown formatting Dec 29, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants