-
Notifications
You must be signed in to change notification settings - Fork 121
[Draft] Support for multiple return values from go function to python #282
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
[Draft] Support for multiple return values from go function to python #282
Conversation
Support for variadic functions
658c6f9
to
1908f17
Compare
Some memory leaks exist. |
Yeah, would it make sense to delete this PR for the time being and rebase on the variadic version which I will test now. The variadic one does not have any leaks? |
you can resubmit a PR once you have it working with out leaks I mean. |
Sure. Variadic shouldn't have leaks. I may take up fixing of memory leaks later as per internal priority. |
Actually, it may still make sense to review from the perspective of behavior. Esp. translating error return into exceptions. Also, deleting PRs causes context to be lost. Will suggest making it a draft PR. |
ok.. I'll try to take a look in a few days. Meanwhile in the future, please run your code through gofmt -- that check is failing on test. |
ps. thanks for submitting these fixes -- much appreciated! |
d1091c5
to
9167efa
Compare
…e, even though it doesn't work currently.
…ng un-expected memory freeing and crashes.
ac43046
to
35cda9d
Compare
URL changes are temporary. Made them to test. Will revert before switching PR draft status. JFYI. |
Support for multiple return values from go function to python