Skip to content

feat: allow setting a timeout for mysql try lock #1200

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vgarvardt
Copy link

Timeout for GET_LOCK() for mysql driver is currently hardcoded to 10 seconds. This PR allows setting a custom value for the timeout.

@vgarvardt
Copy link
Author

Tests are failing with

=== NAME  TestMigrate/cockroachdb/cockroach:v1.1.9
    dktest.go:185: Failed: error pulling image: cockroachdb/cockroach:v1.1.9 error: Error response from daemon: manifest for cockroachdb/cockroach:v1.1.9 not found: manifest unknown: manifest unknown
=== NAME  TestMigrate/cockroachdb/cockroach:v2.0.7
    dktest.go:185: Failed: error pulling image: cockroachdb/cockroach:v2.0.7 error: Error response from daemon: manifest for cockroachdb/cockroach:v2.0.7 not found: manifest unknown: manifest unknown
=== NAME  TestMigrate/cockroachdb/cockroach:v1.0.7
    dktest.go:185: Failed: error pulling image: cockroachdb/cockroach:v1.0.7 error: Error response from daemon: manifest for cockroachdb/cockroach:v1.0.7 not found: manifest unknown: manifest unknown
=== NAME  TestMigrate/cockroachdb/cockroach:v2.1.3
    dktest.go:185: Failed: error pulling image: cockroachdb/cockroach:v2.1.3 error: Error response from daemon: manifest for cockroachdb/cockroach:v2.1.3 not found: manifest unknown: manifest unknown
--- FAIL: TestMigrate (0.00s)
    --- FAIL: TestMigrate/cockroachdb/cockroach:v1.1.9 (0.12s)
    --- FAIL: TestMigrate/cockroachdb/cockroach:v2.0.7 (0.13s)
    --- FAIL: TestMigrate/cockroachdb/cockroach:v1.0.7 (0.13s)
    --- FAIL: TestMigrate/cockroachdb/cockroach:v2.1.3 (0.14s)

that has nothing to do with the PR

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant