-
Notifications
You must be signed in to change notification settings - Fork 460
Add digit separators #1160
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Add digit separators #1160
Conversation
I'm in favor of this. We need to also:
See https://github.com/google/jsonnet?tab=readme-ov-file#locally-serving-the-website for working on documentation.
|
Thanks @sbarzowski, I'll get cracking on those. |
@sbarzowski I think I'm ready for another round of feedback on this one. I suspect these might need a little more help:
|
Anything I can do to push this forward @sbarzowski? Thanks! |
Sorry for all the delays on this. I do hope to review this soon; it seems like a useful improvement. |
@johnbartholomew I'll try to find a few minutes to get this PR back into a healthy/mergable state. If you have any pre-review feedback or changes I can get those going. |
This PR adds digit separators (
1_000
) to Jsonnet's numeric constants.Accompanying issue with format proposal: #1155