Skip to content

fix(dashboard): Recreate dashboard when folderRef is updated #1994

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
May 16, 2025

Conversation

Baarsgaard
Copy link
Collaborator

@Baarsgaard Baarsgaard commented May 11, 2025

Fixes two bugs:

  1. Dashboards are not moved when .spec.folderRef is changed.
  2. Folders owned by a CR or other tool are deleted if empty, usually indicated by folderRef and folderUID

fixes: #1930

@github-actions github-actions bot added the bugfix this PR fixes a bug label May 11, 2025
@Baarsgaard Baarsgaard force-pushed the fix_move_dashboard_on_folder_ref_change branch from 3c3c042 to 5674b98 Compare May 11, 2025 21:59
@Baarsgaard Baarsgaard marked this pull request as ready for review May 12, 2025 11:14
…or FolderUID

FolderRef and FolderUID usually indicates the folder is owned by something else
@Baarsgaard Baarsgaard force-pushed the fix_move_dashboard_on_folder_ref_change branch from 906966d to 4bbaecb Compare May 12, 2025 17:20
@theSuess theSuess added this pull request to the merge queue May 16, 2025
Merged via the queue into master with commit 0b2929e May 16, 2025
19 checks passed
@theSuess theSuess deleted the fix_move_dashboard_on_folder_ref_change branch May 16, 2025 09:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bugfix this PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grafana-operator doesn't trigger on grafanadashboard folder changing
2 participants