Skip to content

Remove python setup.py test #326

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

akx
Copy link

@akx akx commented Jul 29, 2024

For compatibility with setuptools>=72 (which removes the test command altogether)

See pypa/setuptools#931

For compatibility with setuptools>=72 (which removes the test command altogether)

See pypa/setuptools#931
Copy link

@satyasrc satyasrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Works.

Screenshot 2024-07-29 at 5 44 47 PM

PS: Remove tox from requirements-dev.txt. See attached screenshot for reference

@akx
Copy link
Author

akx commented Jul 29, 2024

PS: Remove tox from requirements-dev.txt. See attached screenshot for reference

I don't think that's necessary.

Nothing in the repository refers to requirements-dev.txt, I believe it's for developers' convenience only, in which case pip install -r requirements-dev.txt && tox is a sensible workflow.

@satyasrc
Copy link

satyasrc commented Jul 29, 2024

I am following the consensus agreed to in pypa/setuptools#931

tox doesn't seem to add any value whatsover even in dev and infact is not recommended for linux python environments (See: pypa/setuptools#931 (comment)
It's not used anywhere so if you are removing it from setup.py, it makes sense you remove it from requirements-dev.txt as well as it will substantially reduce the dependency tree and also for the sake of consistency and brevity.

Having said that, I don't have any problem if the contributers or members agree to keeping tox. Maybe removing tox from requirements-dev in a separate PR after this commit is merged would be wiser?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants