Fix validate command not logging filename with only deprecations #2884
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.
Description
printInvalidDocuments checked always checked whether errors field of an invalid document was not empty before rendering deprecated fields usage. This meant that if a file with operation that used a deprecated field did not have any errors, there would be a message "Detected 1 document with deprecated fields:" without listing the file or the deprecation warning itself.
Fixes #2883
Type of change
Please delete options that are not relevant.
expected)
Screenshots/Sandbox (if appropriate/relevant):
Adding links to sandbox or providing screenshots can help us understand more about this PR and take
action on it as appropriate
How Has This Been Tested?
Added relevant unit test for the change. Tested it on local machine via creating 2 files, one with schema with deprecated field and one with operation that uses said deprecated field.
Test Environment:
@graphql-inspector/...
:Checklist:
CONTRIBUTING doc and the
style guidelines of this project
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose
the solution you did and what alternatives you considered, etc...