Skip to content

fix(issue-2139): bigint timestamps #2163

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

design1online
Copy link

@design1online design1online commented Oct 12, 2023

Description

This resolves the problem with using a bigint for timestamps in the database.

Related #2139

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Run the same test as provided in the issue.

Test Environment:

  • OS: MacOS
  • GraphQL Scalars Version: 1.22.4
  • NodeJS: v18.x

Checklist:

  • [] I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@ardatan
Copy link
Member

ardatan commented Oct 13, 2023

This breaks the support for milliseconds, and this would be a breaking change. If we kept the support for ms timestamps, that would be ok.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants