fix: Dataloader helper Try classcast exception #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameerabdul
commented
Mar 10, 2025
| valuesInKeyOrder.set(listIndex, (Try<V>) v); | ||
| } else { | ||
| valuesInKeyOrder.set(listIndex, Try.succeeded(v)); | ||
| } | ||
| } | ||
| List<V> assembledValues = valuesInKeyOrder.stream().map(Try::get).collect(toList()); |
There was a problem hiding this comment.
this might be a bigger change as I can't go a Try.get on failed instances
|
Can we please have a unit test showing this working. Its not enough to fix the code, we need to lock in that behavior |
|
I managed to do a reproducton of this. I can confirm its a genuine problem but this is not the fix for it |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
newMappedDataLoaderWithTryandbatchingEnabledasfalseandcachingEnabledastrue.valueto which is already aTryinstance to be wrapped again in anotherTry.succeedcausing class cast exception