Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

pedantic Clippy fixes #512

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

pedantic Clippy fixes #512

wants to merge 25 commits into from

Conversation

danieleades
Copy link
Contributor

No description provided.

@danieleades danieleades marked this pull request as ready for review January 31, 2025 09:53
@danieleades
Copy link
Contributor Author

note that these changes bump the MSRV (which may not be desirable)!

@tomhoule
Copy link
Member

Thanks for doing this. Let's bump the MSRV and release this once 0.15.0 is out. I expect 0.16.0 to have a bunch of breaking changes.

daniel.eades and others added 25 commits February 11, 2025 16:01
fix formatting
cba75ea
use inline format args (clippy::uninlined_format_args)
e732145
use 'Self' keyword (clippy::use_self)
9fc24cc
use semicolon if nothing returned (clippy::semicolon_if_nothing_retur…
890979d 
…ned)
remove explicit 'iter' loops (clippy::explicit_iter_loop)
3fbac33
avoid cloning when you can copy (clippy::cloned_instead_of_copied)
11d2494
remove unnecessary semicolons (clippy::unnecessary_semicolons)
47f7315
nest or patterns (clippy::unnested_or_patterns)
fc76085
use 'if let' rather than single match 'else' block (clippy::single_ma…
f78c26c 
…tch_else)
collapse some 'if else' blocks
b4a69b7
remove needless raw string hashes (clippy::needless_raw_string_hashes)
81abeb1
remove wildcard imports (clippy::wildcard_imports)
72b4292
bump MSRV
d43b207
flip unnecessary booleans (clippy::if_not_else)
0e9fb1a
remove redundant 'else' block (clippy::redundant_else)
6188068
use 'assert' macro (clippy::manual_assert)
cf12498
explicitly match unit values (clippy::ignored_unit_patterns)
11714a6
@danieleades
remove some redundant closures (clippy::redundant_closure)
50c184b
@danieleades
remove use of 'lazy_static' (clippy::non_std_lazy_statics)
d52a52d
@danieleades
bump msrv
a65d465
@danieleades
remove some needlessly mutable references (clippy::needless_pass_by_r…
6cf0477 
…ef_mut)
@danieleades
general refactoring
154d29d
@danieleades
deglob another import
2ec7fc9
@danieleades
remove unnecessary wraps (clippy::unnecessary_wraps)
bacc011
minor refactoring
d2f53d0
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danieleades @tomhoule