Skip to content

make react and react dom peer(+dev) deps #1391

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

make react and react dom peer(+dev) deps #1391

wants to merge 1 commit into from

Conversation

dweste01
Copy link

Fixes #1298

Changes proposed in this pull request:

  • Make react and react-dom peer dependencies (+ dev dependencies) instead of regular dependencies

@dweste01
Copy link
Author

Not sure why I'm getting size limit warning on the Netlify build (assuming that warning is treated like an error), but locally it builds to a much smaller bundle:

Compiled successfully.
File sizes after gzip:
  662.44 KB  build/static/js/index.js
  652.1 KB   build/static/js/middleware.js
  390 B      build/static/css/middleware.css
  386 B      build/static/css/index.css

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

react-redux and redux should be peer dependencies
1 participant
@dweste01