smugmug_fs: gracefully degrade for video files with no mtime #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes (as with the renames, I have no idea what triggers this) SmugMug doesn't record a DateTimeModified for a video (presumably other filetypes too, but we use MD5 checks for most other files) and we would crash when checking the empty-string that we got back. Instead just assume that the file isn't modified and move on.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes (as with the renames, I have no idea what triggers this)
SmugMug doesn't record a DateTimeModified for a video (presumably
other filetypes too, but we use MD5 checks for most other files) and
we would crash when checking the empty-string that we got
back. Instead just assume that the file isn't modified and move on.