Additional tests and create_target changes #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test if xml content gets escaped and invalid xml is handled when using XmlCommand.
Mark parameters as optional and add hint for returned value.
This commit also changes the API of create_target because the parameters have changed. Now the ids are passed a argument directly instead of passed within a dict. We are not going to follow the GMP protocol 1:1 anymore.
Update create_target tests to test Gmp object directly instead of GmpCommandFactory.
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
- Coverage 22.76% 21.94% -0.83%
==========================================
Files 9 9
Lines 2029 2005 -24
==========================================
- Hits 462 440 -22
+ Misses 1567 1565 -2
Continue to review full report at Codecov.
|
wiegandm
approved these changes
Nov 6, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.