Add test for osp start_scan() #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not add this element if it is empty, since it is not mandatory for OSP, but it must not be empty if it is added.
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
+ Coverage 26.82% 29.11% +2.28%
==========================================
Files 9 9
Lines 2009 2009
==========================================
+ Hits 539 585 +46
+ Misses 1470 1424 -46
Continue to review full report at Codecov.
|
bjoernricks
reviewed
Nov 6, 2018
|
|
||
| self.osp.start_scan( | ||
| scan_id='123-456', | ||
| parallel='10', |
There was a problem hiding this comment.
Should be an int
Suggested change
| parallel='10', | |
| parallel=10, |
| def test_start_scan_legacy(self): | ||
| self.osp.start_scan( | ||
| scan_id='123-456', | ||
| parallel='10', |
There was a problem hiding this comment.
same here
Suggested change
| parallel='10', | |
| parallel=10, |
bjoernricks
approved these changes
Nov 6, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fix add vt_selection element.