API Cleanup #27
Merged
API Cleanup #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some glitches in the created docs.
Was a copy&paste mistake
Not sure if gvmd will strip that spaces. So be save and remove them when sending the request.
Besides the other methods which followed the gmp protocol 1:1 the create_task was missing many optional elements. With this change only the optional preferences are still missing.
Currently it's not clear which format is expected. Therefore use lists which can be converted to each possible textual list format.
All create command are converted now and we can consider the create_xyz methods api as finished.
hosts argument is expected to be a list now.
jjnicola
reviewed
Nov 7, 2018
jjnicola
reviewed
Nov 7, 2018
Update to use Gmp instead of GmpCommandFactory
The scan_id is required.
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
- Coverage 31.73% 31.63% -0.11%
==========================================
Files 9 9
Lines 1963 1960 -3
==========================================
- Hits 623 620 -3
Misses 1340 1340
Continue to review full report at Codecov.
|
jjnicola
approved these changes
Nov 7, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move create commands to Gmp class