API cleanup #30
Merged
API cleanup #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing the copy parameter already doesn't work as expected. It seems that the other parameters send over the wire are ignored by gvmd or even like with task or target name lead to an error. Therefore introduce clone methods that just expect an id as parameter and remove the copy parameter from all create methods.
Currently with this low level api the file will grow even more. So it doesn't make sense to warn for to many lines.
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 32.16% 32.42% +0.26%
==========================================
Files 9 9
Lines 1906 1940 +34
==========================================
+ Hits 613 629 +16
- Misses 1293 1311 +18
Continue to review full report at Codecov.
|
jjnicola
approved these changes
Nov 7, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move cloning to extra methods