Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add test for set_attributes #5

Merged
merged 2 commits into from
Nov 2, 2018
Merged

Add test for set_attributes #5

merged 2 commits into from
Nov 2, 2018

Conversation

wiegandm
Copy link
Member

@wiegandm wiegandm commented Nov 2, 2018

This commit adds a test for the last remaining untested method of the
XmlCommandElement class, set_attributes.

This commit adds a test for the last remaining untested method of the
`XmlCommandElement` class, `set_attributes`.
@wiegandm wiegandm requested review from bjoernricks and a team November 2, 2018 13:27
@codecov
Copy link

codecov bot commented Nov 2, 2018

Codecov Report

Merging #5 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master       #5     +/-   ##
=========================================
+ Coverage   12.56%   12.66%   +0.1%     
=========================================
  Files           9        9             
  Lines        1974     1974             
=========================================
+ Hits          248      250      +2     
+ Misses       1726     1724      -2
Impacted Files Coverage Δ
gvm/xml.py 18.51% <0%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c80c96...92cd065. Read the comment docs.

@bjoernricks bjoernricks merged commit d76745c into greenbone:master Nov 2, 2018
@wiegandm wiegandm deleted the more_tests branch November 5, 2018 07:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants