Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

stub: fix onError metadata race condition #11979

Merged
merged 2 commits into from
Apr 7, 2025
Merged

stub: fix onError metadata race condition #11979

merged 2 commits into from
Apr 7, 2025

Conversation

JoeCqupt
Copy link
Contributor

@JoeCqupt JoeCqupt commented Mar 25, 2025 •
edited
Loading

#11973

this maybe have a little performance implications.

@JoeCqupt
Copy link
Contributor Author

JoeCqupt commented Mar 25, 2025 •
edited
Loading

PTAL @kannanjgithub @ejona86

@kannanjgithub kannanjgithub requested a review from ejona86 April 7, 2025 14:41
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Apr 7, 2025
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Apr 7, 2025
@ejona86 ejona86 merged commit 54d3783 into grpc:master Apr 7, 2025
16 checks passed
@ejona86
Copy link
Member

ejona86 commented Apr 7, 2025

Thank you!

ejona86 pushed a commit to ejona86/grpc-java that referenced this pull request Apr 7, 2025
@JoeCqupt @ejona86
stub: trailersFromThrowable() metadata should be copied (grpc#11979)
8a4ef4d 
If the same exception is passed to multiple RPCs, then the results will
race.

Fixes grpc#11973
@ejona86 ejona86 mentioned this pull request Apr 7, 2025
Merged
kannanjgithub pushed a commit that referenced this pull request Apr 8, 2025
@ejona86 @JoeCqupt
stub: trailersFromThrowable() metadata should be copied (#11979) (#12008
a6e1c1f 
)

If the same exception is passed to multiple RPCs, then the results will race, which this fix addresses.

Fixes #11973

Co-authored-by: jiangyuan <joe469391363@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ejona86 ejona86 ejona86 approved these changes

@kannanjgithub kannanjgithub kannanjgithub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoeCqupt @ejona86 @kannanjgithub @grpc-kokoro