xds: Enable deprecation warnings #11998
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The security code referenced fields removed from gRFC A29 before it was finalized.
ejona86
commented
Apr 4, 2025
| @@ -536,8 +525,6 @@ static void validateCommonTlsContext( | |||
| private static String getIdentityCertInstanceName(CommonTlsContext commonTlsContext) { | |||
| if (commonTlsContext.hasTlsCertificateProviderInstance()) { | |||
| return commonTlsContext.getTlsCertificateProviderInstance().getInstanceName(); | |||
| } else if (commonTlsContext.hasTlsCertificateCertificateProviderInstance()) { | |||
There was a problem hiding this comment.
Ugh. Apparently these might actually be needed. TODO: investigate
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The security code referenced fields removed from gRFC A29 before it was finalized.