Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Captcha #184

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Captcha #184

wants to merge 3 commits into from

Conversation

ArturG
Copy link
Contributor

@ArturG ArturG commented Feb 22, 2014

Hey! I didn't find gem that supports mongo-mapper, so I had to extend simple_captcha :) Unfortunately, the author of the original gem is inactive more than one month, so we are using my version https://github.com/ArturG/simple-captcha in the Gemfile. Probably this is not the best solution, so feel free to fork my repo and replace the link (to get rid of dependence). Thanks

Preview:
screen shot 2014-02-21 at 11 38 11 pm

@ArturG
Copy link
Contributor Author

ArturG commented Feb 22, 2014

Oh, and yes...tests are coming soon...

@PragTob
Copy link
Member

PragTob commented Feb 23, 2014

Hi there,

jay you're on a roll! Thanks for your contribution! This looks good but yeah tests would be cool/easing my mind just dunno how hard they are :) If you need help let me know.

Will take a deeper look at this/try it out next week. If I don't please nudge me here.

Also the upgrade Rails commits seem to be duplicated here - if you feel comfortable removing them or making a new PR with only the captcha changes that'd be cool. Otherwise I'll just do it when merging (e.g. do not try to invest too much time into that).

Cheers + thanks!
Tobi

@ArturG
Copy link
Contributor Author

ArturG commented Feb 25, 2014

I'm glad to know you're happy :) I will try to complete the work in few days, sorry for the delay.

P.S I've removed duplicates

@ArturG
Copy link
Contributor Author

ArturG commented Feb 26, 2014

@PragTob Wrote tests for the answers controller. Please, take a look whenever you will have time :) Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants