-
Notifications
You must be signed in to change notification settings - Fork 637
support pcapng file format #1936
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Conversation
1a841c3
to
8d47c73
Compare
try: | ||
import pyzstd | ||
except ImportError: | ||
pyzstd = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zstandard addition should be a distinct commit. Please let me know if you would like to merge with squashing so that I can split it out into a new PR
It is useful for both using SocketCAN devices and pcap(ng) files storing SocketCAN packets
Keep the changes minimal. Move the socketcan files back to where they belong, remove zstd and all other unrelated changes. Add test data and documentation (see file_io.rst) |
I abstracted out some common SocketCAN files for the purpose of not duplicating the code. pcapng expects packets to be serialized as SocketCAN packets, so this code has to be shared. Let me know if there is a better place or way to refactor this. |
you could just import from socketcan without moving the files |
Is this a correct pattern for an IO module to import an interface module? That felt a bit counter-logical |
This PR adds support for Pcapng files to the I/O module
Related to #1403, pcap should be rather simple to implement based on these changes.
TODO:
lz4, zst, perhaps other compression types readers know about