Skip to content

parse socketcand error messages to create a CAN error frame #1941

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jun 12, 2025

Conversation

occam25
Copy link
Contributor

@occam25 occam25 commented May 22, 2025

Summary

Recently socketcand project merged a PR to enable error CAN frames ( linux-can/socketcand#67 ) so now it can send error messages through the TCP socket when an error frame is generated by the CAN driver.

This PR updates the python-can socketcand interface to generate an error CAN message when socketcand error message is received

@zariiii9003
Copy link
Collaborator

Could you add some test for this?

@occam25
Copy link
Contributor Author

occam25 commented Jun 12, 2025

Could you add some test for this?

Hi @zariiii9003 ,
I have added the test. Please, have a look
Thks

@occam25 occam25 force-pushed the process_socketcand_error_messages branch from fa53e32 to b30b834 Compare June 12, 2025 14:38
Copy link
Collaborator

@zariiii9003 zariiii9003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you 👍

@zariiii9003 zariiii9003 merged commit 8970fce into hardbyte:main Jun 12, 2025
30 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants