Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make hide_results_on_select option apply for deselecting as well #2924

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

VanTanev
Copy link

Summary

hide_results_on_select: false option currently applies only for selecting options. It should apply on deselect as well, as custom skinning of chosen can make use of it.

Please double-check that:

  • All changes were made in CoffeeScript files, not JavaScript files.
  • You used Grunt to build the JavaScript files and tested them locally.
  • You've updated both the jQuery and Prototype versions.
  • You haven't manually updated the version number in package.json.
  • If necessary, you've updated the documentation. -
    I am unsure if this neccesitates a documentation change, as I think that this should have been the intended behavior of the option.

@cgatesman
Copy link

I believe this request is the same as what I'm looking for. To further explain, when using hide_results_on_select: false, it would be nice to be able to click on already selected items (which are currently greyed out) in order to unselect them (as if you clicked on the x of the .search-choice).

@VanTanev
Copy link
Author

Updated to also not scroll the dropdown menu to top when hide_results_on_select: false.

@JJJ JJJ mentioned this pull request Jul 22, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants