Update Proof of reserve doc & tests refactor #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amatsonkali
changed the title
amatsonkali
added
documentation
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update bitcoin vaults Docs & tests refactor
Overview
The bitcoin vaults documentation was missing the Proof of Reserve overview (both on CLI & Js library).
Additionally, a refactor of the pallet tests was performed to save a few hundred lines of code.
Tickets
List the tickets of the PR linked
Implementation notes
All the long tx were wrapped in functions, leaving all the dummy data intact.
Test coverage
This PR affects all of the Bitcoin vaults tests.
Loose ends
Finding a way to submit an unsigned tx with signed payload during tests is still pending.