Skip to content

Switch to Boost.JSON #1590

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Switch to Boost.JSON #1590

wants to merge 2 commits into from

Conversation

andrey-kashcheev
Copy link
Collaborator

Relates-To: DATASDK-58

@andrey-kashcheev andrey-kashcheev force-pushed the datasdk-58-boost-json branch 8 times, most recently from 2784c1e to 8c034da Compare February 11, 2025 13:12
Relates-To: DATASDK-58

Signed-off-by: Andrey Kashcheev <ext-andrey.kashcheev@here.com>
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 87.34491% with 102 lines in your changes missing coverage. Please review.

Project coverage is 81.46%. Comparing base (e80ea0b) to head (9dd546d).

Files with missing lines Patch % Lines
...dk-authentication/src/AuthenticationClientImpl.cpp 73.68% 23 Missing and 7 partials ⚠️
...ice-read/src/repositories/PartitionsSaxHandler.cpp 86.59% 11 Missing ⚠️
...e/src/generated/serializer/IndexInfoSerializer.cpp 66.67% 8 Missing and 2 partials ⚠️
...erated/serializer/UpdateIndexRequestSerializer.cpp 70.59% 8 Missing and 2 partials ⚠️
...k-authentication/src/AuthenticationClientUtils.cpp 75.86% 1 Missing and 6 partials ⚠️
...ataservice-read/src/repositories/QuadTreeIndex.cpp 84.21% 2 Missing and 4 partials ⚠️
olp-cpp-sdk-authentication/src/BaseResult.cpp 68.75% 1 Missing and 4 partials ⚠️
...p-sdk-authentication/src/ResponseFromJsonBuilder.h 78.95% 1 Missing and 3 partials ⚠️
...pp-sdk-authentication/src/SignInUserResultImpl.cpp 69.23% 0 Missing and 4 partials ⚠️
...lp-cpp-sdk-authentication/src/SignInResultImpl.cpp 84.21% 0 Missing and 3 partials ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1590      +/-   ##
==========================================
+ Coverage   81.39%   81.46%   +0.07%     
==========================================
  Files         345      344       -1     
  Lines       13549    13512      -37     
  Branches     1464     1471       +7     
==========================================
- Hits        11027    11007      -20     
+ Misses       1927     1916      -11     
+ Partials      595      589       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrey-kashcheev andrey-kashcheev force-pushed the datasdk-58-boost-json branch 2 times, most recently from c7e4b7e to e3fd3f4 Compare February 11, 2025 14:27
Complete overhaul

Relates-To: DATASDK-58

Signed-off-by: Andrey Kashcheev <ext-andrey.kashcheev@here.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant