Renamed sched.test_cmd to sched.launch and added alias #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paul-Ferrell
requested changes
Mar 5, 2024
lib/pavilion/commands/__init__.py
Outdated
| @@ -42,6 +42,7 @@ | |||
| 'set_status': ['status_set'], | |||
| 'result': ['results'], | |||
| 'list_cmd': ['list'], | |||
| 'launch': ['test_cmd'], | |||
There was a problem hiding this comment.
These are aliases for Pavilion commands, not the sched.test_cmd variable.
There was a problem hiding this comment.
I don't see the alias in the for test_cmd->launch. It should probably go in the base class for SchedulerVariables.
Removed alias since this is not the alias we want
Paul-Ferrell
requested changes
Mar 21, 2024
| @@ -111,7 +111,7 @@ command. | |||
| | | | 1. | |||
| tasks_total | True | 180 | Total tasks to create, based on number of nodes | |||
| | | | actually acquired. | |||
| test_cmd | True | srun -N 5 -w no | Construct a cmd to run a process under this | |||
| launch | True | srun -N 5 -w no | Construct a cmd to run a process under this | |||
There was a problem hiding this comment.
I'd add a (formerly sched.test_cmd) to the docs here.
| @@ -155,7 +155,7 @@ def partition(self): | |||
|
|
|||
| return self._sched_config['partition'] or '' | |||
|
|
|||
| def _test_cmd(self): | |||
| def _launch(self): | |||
There was a problem hiding this comment.
You're still missing the alias.
There was a problem hiding this comment.
Wrap the alias as a @dfr_var_method - that way it will work regardless of whether or not the function is deferred in any child class.
added to documentation table that used to be sched.test_cmd
this is the REAL fix to creating an alias for the older way of launching
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code review checklist: