Parse seed for vLLM #602
Merged
Parse seed for vLLM #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When seed is set through model_args, for example: ```bash "pretrained=deepseek-ai/DeepSeek-R1-Distill-Qwen-1.5B,seed=123,dtype=bfloat16,max_model_length=38768,gpu_memory_utilization=0.8,tensor_parallel_size=1" `` it is parsed as a string attribute in `VLLMModelConfig`, leading to an error during LLM initialization: ```python model = LLM(**self.model_args) ``` This PR ensures that seed is correctly cast to an integer before passing it to the model, preventing initialization errors.
|
Same problem! |
NathanHB
approved these changes
Apr 8, 2025
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
hynky1999
pushed a commit
that referenced
this pull request
May 22, 2025
When seed is set through model_args, for example: ```bash "pretrained=deepseek-ai/DeepSeek-R1-Distill-Qwen-1.5B,seed=123,dtype=bfloat16,max_model_length=38768,gpu_memory_utilization=0.8,tensor_parallel_size=1" `` it is parsed as a string attribute in `VLLMModelConfig`, leading to an error during LLM initialization: ```python model = LLM(**self.model_args) ``` This PR ensures that seed is correctly cast to an integer before passing it to the model, preventing initialization errors. Co-authored-by: Nathan Habib <30601243+NathanHB@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When seed is set through model_args, for example:
"pretrained=deepseek-ai/DeepSeek-R1-Distill-Qwen-1.5B,seed=123,dtype=bfloat16,max_model_length=38768,gpu_memory_utilization=0.8,tensor_parallel_size=1"it is parsed as a string attribute in
VLLMModelConfig, leading to an error during LLM initialization:This PR ensures that seed is correctly cast to an integer before passing it to the model, preventing initialization errors.