-
Notifications
You must be signed in to change notification settings - Fork 249
Add support for JinaAI Re-rankers #582
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Open
alvarobartt
wants to merge
13
commits into
main
Choose a base branch
from
jina-reranker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
It's smaller and just created the PR to add support for TEI
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the
JinaBertClassificationHead
in order to support the JinaBERT re-ranking models as e.g.jinaai/jina-reranker-v1-turbo-en
. Note that JinaBERT's classification head is exactly the same as standard BERT's.Warning
This PR is not yet ready to be merged, as there seem to be some discrepancies between the Sentence Transformers and ONNX outputs (those are aligned), but the outputs for the default Candle backend is not, meaning that there may be something off somewhere. Also it has yet only been tested on CPU and MPS devices, CUDA support is still missing / pending.
Fixes #579
Before submitting
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.