Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feat refactor advanced network capture #93

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

tzurae
Copy link

@tzurae tzurae commented Mar 29, 2024

Background

Customers can use the networkHeadersCapture and networkBodyCapture flags to decide whether to capture header or body information. Additionally, we will issue a warning when customers are still using advancedNetworkCapture in the current version, informing them that the advancedNetworkCapture flag will be deprecated in the next version.

export type SDKConfig = {
  advancedNetworkCapture?: boolean;
  networkHeadersCapture?: boolean; // new flag
  networkBodyCapture?: boolean; // new flag
  betaMode?: boolean;
  consoleCapture?: boolean;
  instrumentations?: InstrumentationConfigMap;
  additionalInstrumentations?: InstrumentationBase[];
  stopOnTerminationSignals?: boolean;
};

Copy link

changeset-bot bot commented Mar 29, 2024

🦋 Changeset detected

Latest commit: 15d59de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hyperdx/node-opentelemetry Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tzurae tzurae requested a review from wrn14897 March 29, 2024 17:50
@wrn14897
Copy link
Member

wrn14897 commented Mar 29, 2024

We also need to update README.md and mention new env flags HDX_NODE_NETWORK_HEADERS_CAPTURE and HDX_NODE_NETWORK_BODY_CAPTURE

@tzurae tzurae requested a review from MikeShi42 March 31, 2024 13:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants