fix: one exporter to rule them all #243
Conversation
one exporter for all registered services
| } | ||
| case config.TraceReporterType_LOGGING: | ||
| return func() (sdktrace.SpanExporter, error) { | ||
| // TODO: Define if endpoint could be a filepath to write into a file. | ||
| return stdouttrace.New(stdouttrace.WithPrettyPrint()) | ||
| globalExporter, globalExporterErr = stdouttrace.New(stdouttrace.WithPrettyPrint()) |
There was a problem hiding this comment.
Does this need to be thread safe? If yes, do we need to worry about races resulting in some dangling exporters or that’s not a big deal?
There was a problem hiding this comment.
Maybe not since it would set up in the Init method. Unless all the consumers do not call Init. But I will shelf this one for now since I did not observe any remarkable improvement with one exporter vs multiple exporters.
There was a problem hiding this comment.
Not opposed to shelving it, but why no improvement? This should help to reduce number of export connections?
There was a problem hiding this comment.
I didn't have time to verify that using lsof or some other networking tool. I suspect reducing clients does not mean reducing connections as well. The clients maybe fewer but the connection count may still be the same. I would want to verify it next.
|
Closing this one |
Description
One exporter for all registered services. We are currently creating a new exporter every time a new service is registered which results in multiple grpc clients to the collector being created.
Testing
Manual tests
Checklist: