Grpc cb utility update #70
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added config key support to define nested (channel level) configurations.
For Ex :
Circuit Breaker Key - TenantId (defined by key function)
Config Key : S3 (notification channel)
Even though circuit breaker objects can be different for different tenants, we can define the CB configuration at channel level
Testing
Tested changes on sandbox environment using this utility. Unit Tests added and validated.
Scenarios :
i. Config Key Set, Thresholds defined for config key => should pick thresholds against config key
ii. Config Key Set, Thresholds not defined for config key => should pick default thresholds
iii. Config key not set => should pick default thresholds
Jira : https://harness.atlassian.net/browse/ENGTAI-60244