Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

IBX-8674: Improve product completeness and attribute definitions #2617

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dabrt
Copy link
Contributor

@dabrt dabrt commented Feb 17, 2025

Question Answer
JIRA Ticket IBX-8674
Versions 4.6
Edition all

Improve product completeness and attribute definitions to add ifnofrmation about limitations, suggested usage and impact.

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Added link to this PR in relevant JIRA ticket or code PR

Copy link

Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as in user doc - attribute names are translatable (and one additional remark about wording).

!!! note "Attribute translations"

Product attributes are not translatable.
Unlike content fields, product attribute names and values cannot differ between languages.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Names can be translated (see user doc review)

Product attributes are not translatable.
Unlike content fields, product attribute names and values cannot differ between languages.

To help mitigate this limitation, for the information that is intended to be displayed, consider using TextLine fields for short text, RichText fields for longer text that may require formatting, and product attributes for precise product properties or specifications.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't use the word "limitation".

Attribute values are not translatable, because they are for properties of the product - which remain the same regardless of the language.

For all the things that need to be translatable (marketing content: descriptions, names, etc.) people should use content fields.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants