Task Scheduling Readme Update #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task scheduling in laravel 11
ichtrojan
reviewed
Dec 22, 2024
| @@ -135,6 +135,16 @@ protected function schedule(Schedule $schedule) | |||
| $schedule->command('otp:clean')->daily(); | |||
| } | |||
| ``` | |||
ichtrojan
reviewed
Dec 22, 2024
README.md
Outdated
| @@ -135,6 +135,16 @@ protected function schedule(Schedule $schedule) | |||
| $schedule->command('otp:clean')->daily(); | |||
| } | |||
| ``` | |||
| In laravel 11 the `app/Console/Kernel.php` was removed, to schedule a task, add this to the `routes/console.php` | |||
There was a problem hiding this comment.
leave a newline before the code sample
ichtrojan
reviewed
Dec 22, 2024
README.md
Outdated
|
|
||
| Schedule::command('otp:clean')->daily(); | ||
| ``` | ||
| check if your task has been added to schedule using command: |
There was a problem hiding this comment.
leave a newline after the code sample
ichtrojan
reviewed
Dec 22, 2024
README.md
Outdated
| Schedule::command('otp:clean')->daily(); | ||
| ``` | ||
| check if your task has been added to schedule using command: | ||
| `php artisan schedule:list` |
There was a problem hiding this comment.
php artisan schedule:listshould be a code sample with bash as opposed to php artisan schedule:list
leave a new line before and after its declaration
Added requested changes to the readme 👍
ichtrojan
reviewed
Dec 23, 2024
| @@ -136,6 +136,21 @@ protected function schedule(Schedule $schedule) | |||
| } | |||
| ``` | |||
|
|
|||
| In Laravel 11, the `app/Console/Kernel.php` file has been removed. To schedule a task, you can now add it directly to `routes/console.php` as follows: | |||
| ```php | |||
ichtrojan
reviewed
Dec 23, 2024
| ``` | ||
|
|
||
| You can check if your task has been added to the schedule by using the following artisan command: | ||
| ```bash |
ichtrojan
reviewed
Dec 23, 2024
| php artisan schedule:list | ||
| ``` | ||
|
|
||
|
|
|
Bumping this up |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task scheduling in laravel 11