-
-
Notifications
You must be signed in to change notification settings - Fork 205
chore: update arpack to arpack-ng 3.9.1 #1559
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Conversation
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
ad0e186
to
9a7ba0a
Compare
9a7ba0a
to
9e27ffc
Compare
@krlmlr I am quite certain that this is better than the old version, despite the test failures. That said, the tests need to be dealt with carefully before going ahead, and I won't have time for this before 2.2.0. However, running revdepchecks for this would be quite useful, to test if anything in the real world was actually broken by this change. I'm not sure if that's possible before fixing our tests @krlmlr . |
Co-authored-by: szhorvat <1212871+szhorvat@users.noreply.github.com>
7062d99
to
ba254aa
Compare
Running revdepchecks now. |
The results don't look terrible, comparing with the main branch now. |
Are you okay with merging this, assuming we can fix the tests? |
Just checked locally. The error occurs at random. Need to have a closer look |
I think it's best if I have a look at this first, and see if the parameters with which ARPACK is called need to be tuned. I'll also need to repro the issue in the C core. Let's delay merging this to the next release, or maybe I can get to it on the weekend. Thanks for running the revdepchecks, this was very useful! On a first skim, I see nothing ARPACK-related, which is indeed good. |
This reverts commit 773b105.
@krlmlr You asked to update ARPACK to the latest ARPACK-NG. This PR attempts to do that. It was quite painful: first we need to rename functions to have an igraph prefix, and avoid conflicts. This can be done automatically. But then the line lengths exceed 72 characters, which is the maximum for fixed-form Fortran, and we need to manually reformat them, with the appropriate continuation character. I hope I didn't mess this up.
The changes to snapshots are fine. But there's a failure with spectral clustering, and it's unclear to me whether that's a real failure or not. I'll have another look at this when teaching is over (mid-November).