[SYCL][UR][L0 v2] fix use after free on queue #18101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igchor
force-pushed
the
event_release_simplify
branch
from
95ad662 to
de67ad7
Compare
igchor
force-pushed
the
event_release_simplify
branch
from
de67ad7 to
e739c9c
Compare
There was a potential race: if getEventEndTimestamp returns false and just after that the queue finishes and is destroyed, we would call deferEventRelease on invalid queue. This patch reworks the logic for deferring event release. Instead of registering the events to be released in the queue, we just clear adjustedEventStartTimestamp and adjustedEventEndTimestamp to mark the event as not timestamped. Since events are never actually destroyed, only returned to the pool, any pending timestamp write will always succeed. Since we are only dealing with in-order queues, the timestamp can only increase.
The queue can already be released.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.