[SYCL] workaround for memaccess warning from older hostcompiler #18435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his simple cast avoids that warning. Signed-off-by: Chris Perkins <chris.perkins@intel.com>
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
approved these changes
May 13, 2025
|
Failed on Arc: Reported in #18416 |
| @@ -24,7 +24,7 @@ inline void memcpy_no_adl(T1 *Dst, const T2 *Src, size_t Size) { | |||
| #ifdef __SYCL_DEVICE_ONLY__ | |||
| __builtin_memcpy(Dst, Src, Size); | |||
| #else | |||
| std::memcpy(Dst, Src, Size); | |||
| std::memcpy(static_cast<void *>(Dst), static_cast<const void *>(Src), Size); | |||
There was a problem hiding this comment.
IMO, this should be done on bit_cast->memcpy_no_adl call, not in memcpy_no_adl->memcpy call.
Also, per https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104855 the warning is correct, so I'm not sure why recent GCCs don't emit it.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older gcc when used as host compiler may trigger memaccess warning. This simple cast avoids that warning.