fix(renderField): use field.localized #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zernie
force-pushed
the
fix/localization-flag
branch
from
753506f to
5e9c36b
Compare
zernie
commented
Jun 5, 2020
| @@ -3,7 +3,8 @@ export default function renderLocalizedTypes(localization: boolean) { | |||
| if (!localization) return null | |||
|
|
|||
| return ` | |||
| export type LocalizedField<T> = Partial<Record<LOCALE_CODE, T>> | |||
| export type DefaultLocalizedField<T> = Record<CONTENTFUL_DEFAULT_LOCALE_CODE, T> | |||
There was a problem hiding this comment.
When we're using locale=* even non-localized fields will be rendered as
"field": {
"<CONTENTFUL_DEFAULT_LOCALE_CODE>": "value"
},
|
hey @stevenpetryk, could you please take a look? |
stpoa
approved these changes
Jul 21, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the
--localizationflag - it does not takefield.localizedinto consideration.This change is