Skip to content

chore(perf): deprecations for v8 API ahead of future major release #8585

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

MichaelVerdon
Copy link
Collaborator

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Jun 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 1:08pm

Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make these three settable from initialisePerformance():
https://github.com/invertase/react-native-firebase/blob/main/packages/perf/lib/index.js#L55-L103

dataCollectionEnabled and isPerformanceCollectionEnabled are the same. The moduler method of initialisePerformance() needs to be updated. See JS docs for the options:

https://firebase.google.com/docs/reference/js/performance.md?_gl=1*wajhyu*_up*MQ..*_ga*NTg3Mjc2MzMuMTc1MDc1MzIxMQ..*_ga_CW55HF8NVT*czE3NTA3NTMyMTAkbzEkZzAkdDE3NTA3NTMyMTAkajYwJGwwJGgw#initializeperformance_980350e

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants