-
Notifications
You must be signed in to change notification settings - Fork 2.3k
chore(perf): deprecations for v8 API ahead of future major release #8585
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make these three settable from initialisePerformance():
https://github.com/invertase/react-native-firebase/blob/main/packages/perf/lib/index.js#L55-L103
dataCollectionEnabled
and isPerformanceCollectionEnabled
are the same. The moduler method of initialisePerformance()
needs to be updated. See JS docs for the options:
Description
Related issues
Release Summary
Checklist
Android
iOS
Other
(macOS, web)e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter