feat(fdc)!: breaking change - Introduce dataConnectResult field to provide fields that were overridden when spreading data
#172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Tanstack Query Angular support
This reverts commit c348aa4.
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/tanstack-query-firebase~172 Documentation is deployed and generated using docs.page. |
maneesht
changed the title
resultMeta field to provide fields that were overridden when spreading datadataConnectResult field to provide fields that were overridden when spreading data
yuchenshi
approved these changes
Mar 17, 2025
|
This is good to go. I saw you've updated the title but don't forget to update the PR description to match the updated API too @maneesht |
|
Done @yuchenshi. Thanks! |
Ehesp
changed the title
dataConnectResult field to provide fields that were overridden when spreading datadataConnectResult field to provide fields that were overridden when spreading data
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user has a field that conflicts with
QueryResultorMutationResultfields such asref, source, they get overridden. This PR includes a newdataConnectResultfield that allows us to expose the entireQueryResult/MutationResultto users. Additionally, we removed all sibling fields ofdata, to reduce other conflicts.