Config param to disable websocket rate limit #562
Merged
+53
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwarnerdev
changed the title
lmoe
approved these changes
Mar 31, 2025
There was a problem hiding this comment.
Looks good!
Sorry for being pedantic, but could you invert the configuration parameter into an Enable flag instead of Deactivate?
Most of our config parameters are like:
nodeconn.Enable
metrics.Enable
I think websocketRateLimitEnabled would suit better. Rather make it default to true inside the webapi/params.go.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a config parameter to disable the websocket rate limits.