Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feat: get images smaller and faster #883

Closed
wants to merge 1 commit into from
Closed

Feat: get images smaller and faster #883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions app/phone/src/main/java/dev/jdtech/jellyfin/BindingAdapters.kt
View file
Original file line number Diff line number Diff line change
@@ -16,12 +16,16 @@ import org.jellyfin.sdk.model.api.ImageType
import java.util.UUID
import dev.jdtech.jellyfin.core.R as CoreR

private const val quality = 96
private const val maxHeight = 408
private const val maxWidth = 272

fun bindItemImage(imageView: ImageView, item: BaseItemDto) {
val itemId =
if (item.type == BaseItemKind.EPISODE || item.type == BaseItemKind.SEASON && item.imageTags.isNullOrEmpty()) item.seriesId else item.id

imageView
.loadImage("/items/$itemId/Images/${ImageType.PRIMARY}")
.loadImage("/items/$itemId/Images/${ImageType.PRIMARY}?fillHeight=$maxHeight&fillWidth=$maxWidth&quality=$quality")
.posterDescription(item.name)
}

@@ -32,15 +36,15 @@ fun bindItemImage(imageView: ImageView, item: FindroidItem) {
}

imageView
.loadImage("/items/$itemId/Images/${ImageType.PRIMARY}")
.loadImage("/items/$itemId/Images/${ImageType.PRIMARY}?fillHeight=$maxHeight&fillWidth=$maxWidth&quality=$quality")
.posterDescription(item.name)
}

fun bindItemBackdropImage(imageView: ImageView, item: FindroidItem?) {
if (item == null) return

imageView
.loadImage("/items/${item.id}/Images/${ImageType.BACKDROP}")
.loadImage("/items/${item.id}/Images/${ImageType.BACKDROP}?fillHeight=$maxHeight&fillWidth=$maxWidth&quality=$quality")
.backdropDescription(item.name)
}

@@ -50,7 +54,7 @@ fun bindItemBackdropById(imageView: ImageView, itemId: UUID) {

fun bindPersonImage(imageView: ImageView, person: BaseItemPerson) {
imageView
.loadImage("/items/${person.id}/Images/${ImageType.PRIMARY}", placeholderId = CoreR.drawable.person_placeholder)
.loadImage("/items/${person.id}/Images/${ImageType.PRIMARY}?fillHeight=$maxHeight&fillWidth=$maxWidth&quality=$quality", placeholderId = CoreR.drawable.person_placeholder)
.posterDescription(person.name)
}

@@ -66,12 +70,12 @@ fun bindCardItemImage(imageView: ImageView, item: FindroidItem) {
}

fun bindSeasonPoster(imageView: ImageView, seasonId: UUID) {
imageView.loadImage("/items/$seasonId/Images/${ImageType.PRIMARY}")
imageView.loadImage("/items/$seasonId/Images/${ImageType.PRIMARY}?fillHeight=$maxHeight&fillWidth=$maxWidth&quality=$quality")
}

fun bindUserImage(imageView: ImageView, user: User) {
imageView
.loadImage("/users/${user.id}/Images/${ImageType.PRIMARY}", placeholderId = CoreR.drawable.user_placeholder)
.loadImage("/users/${user.id}/Images/${ImageType.PRIMARY}?fillHeight=$maxHeight&fillWidth=$maxWidth&quality=$quality", placeholderId = CoreR.drawable.user_placeholder)
.posterDescription(user.name)
}