Added examples of typical errors in JSON #3564
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexandre887
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON methods, toJSON
let json = `{ *!*name*/!*: "John", // mistake: property name without quotes "surname": *!*'Smith'*/!*, // mistake: single quotes in value (must be double) *!*'isAdmin'*/!*: false, // mistake: single quotes in key (must be double) "birthday": *!*new Date(2000, 2, 3)*/!*, // mistake: no "new" is allowed, only bare values @@"gender": "male"*!* */!* // mistake: missing comma after non-last property @@ @@"friends": [0,1,2,3]*!*,*/!* // mistake: there should not be a comma after the last property @@ }`;In practice, many novice developers, following the rule that in JavaScript there can be a "trailing comma" in an object, try to reproduce the same in JSON. But a trailing comma in JSON makes it invalid. This is a very widespread stuff, so I think we should add such an example to "typical mistakes".
Also, many people forget that a comma should be after each property except the last one, which also causes JSON to become invalid. I also added such an example.