Icon and logo support #400
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there's a blog_icon defined in the _config.yml file, then this will insert it as an icon into the Atom feed. (Many readers don't support this, but some do.)
parkr
reviewed
Jan 3, 2024
There was a problem hiding this comment.
Definitely game for this. It needs a test though. The reader I use, NetNewsWire, seems to offer pulling in the favicon but having a custom icon could be neat.
This was helpful for my understanding of these two fields: https://stackoverflow.com/a/29953980
Yeah, NetNewsWire is my reader too, and it doesn’t support this yet. Working on that, too. :-) |
parkr
reviewed
Jan 16, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A patch to support a blog icon and logo via the _config.yml file. Many feed readers will default to using a site's favicon or icon resources, but the Atom spec supports both an icon (square, so with 1:1 proportions) and a logo (2:1 proportions), so this adds them in. I did this with a more generalizable addition to the xml file:
In theory other blog properties could be added here, like a blog title (which I already have set up).