[WIP] [iOS & tvOS] Internal Text Subtitle Offset #1462
Draft
+28
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPKribs
changed the title
|
This is passing all my testing but I honestly have no idea WHY this happening unless there is something wonky with the API? Sorry to bother @LePips, but would you be able to test this out on your end and make sure I'm not missing anything? The fact this varies based on subtitle type makes be nervous I'm missing the bigger picture here... |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves: #1256 (comment)
Similar issue to: jellyfin/jellyfin-webos#85
I don't totally understand this. In my testing on the original fix (#1445) I guess I missed this because I was only using English subtitles and all of my internal subtitles are PGS. The issue appears to be that, when there are ONLY internal SUBRIP subtitles, the first and last subtitles have swapped
DeliveryURLs. I do not understand WHY this is happening but I am able to recreate this consistently when testing with internal SUBRIP subtitle only. External Text-Based subtitles appear to work without issue. Internal Text-Based subtitles appear to work without issue IF there are external subtitles OR a graphic PGS subtitle included.This logic switches the first and last subtitle tracks IF there are only text based subtitles internally. I will need to do some testing since I don't have a lot of files available to test this. Just getting this out there while I test this.
This PR also drops subtitles from transcoding where
.isSupportsExternalStreamis false since those are not selectable.