Skip to content

Stock API and plot function update #22

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TianYuanSX
Copy link

@TianYuanSX TianYuanSX commented Apr 21, 2024

Hi Jingles,

Thanks for this great tutorial. I'm a student interested in Python finance.

I found some parts of the code require updates. And I tried to fix them.

  • plt.grid() no longer accepts keyword b=None. I just removed it. otherwise, this function will raise an exception. See matplotlib.pyplot.grid
  • Fetching the daily adjusted close price is a premium feature now, while a Free API cannot retrieve such data. The daily close price was used instead. See Alpha Vantage API Documentation

Best regards,
Yuan

The keyword argument `b` is no longer available for function `plt.grid()`, just remove it.
`get_daily_adjusted` is a premium api.
Use `get_daily` instead.
@drniwech
Copy link

Thank you, @TianYuanSX, for this PR. It is very helpful for me to run this tutorial without issues. I hope this PR will be reviewed and merged soon.

ofenloch added a commit to ofenloch/time-series-forecasting-pytorch that referenced this pull request Dec 31, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants