Avail PropertyUI types and hide sensitive fields in the destination configuration #1187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ikraamg
commented
Mar 24, 2025
•
ikraamg
commented
- Make the PropertyUI type available in the destination configuration by moving it over (not sure about how to best do this).
- Hide sensitive fields in the destination configuration UI.
ikraamg
commented
Mar 24, 2025
Comment on lines
+37
to
+43
| editor?: | ||
| | "ArrayTextarea" | ||
| | "StringArrayEditor" | ||
| | "CodeEditor" | ||
| | "SnippedEditor" | ||
| | "MultiSelectWithCustomOptions" | ||
| | string; |
There was a problem hiding this comment.
I have added these types for ease of reference. They look to be the only ones currently supported. I have not removed the acceptance of the string type since there is a runtime check for the editor type and I wanted to tread lightly with this change.
ikraamg
changed the title
ikraamg
changed the title
ikraamg
commented
Mar 24, 2025
| @@ -28,7 +30,6 @@ import intercomIcon from "./icons/intercom"; | |||
| import webhookIcon from "./icons/webhook"; | |||
| import { branding } from "../branding"; | |||
| import * as meta from "@jitsu/core-functions/src/meta"; | |||
| import { HubspotCredentials } from "@jitsu/core-functions/src/meta"; | |||
There was a problem hiding this comment.
This was already available via meta.HubspotCredentials
danhemerlein
approved these changes
Apr 9, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.