Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Optimization #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimization #23

wants to merge 1 commit into from

Conversation

ku8ar
Copy link

@ku8ar ku8ar commented Jul 11, 2019

"typeof" is expensive...
Zrzut ekranu 2019-07-11 o 22 09 19

oleksandr-tkach
oleksandr-tkach approved these changes Jul 12, 2019
View reviewed changes
Copy link

@oleksandr-tkach oleksandr-tkach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unbelievable. JS community is grateful!

@jonschlinkert
Copy link
Owner

Unbelievable. JS community is grateful!

Since parseInt('1.FOO', 10) is a number in JavaScript, yes, I'm sure they are. Thanks for taking a break from serving fries to bless us with your kind words!

Repository owner locked as off-topic and limited conversation to collaborators Jul 18, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@adamgajzlerowicz adamgajzlerowicz

@MarcinWalendowski MarcinWalendowski

@oleksandr-tkach oleksandr-tkach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ku8ar @jonschlinkert @adamgajzlerowicz @MarcinWalendowski @oleksandr-tkach @juszczykjakub