Add support for post json body (fix #545) #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR needs unit tests to test the added functionality before it can be accepted. |
|
Added one unit test, for data check. But multi input with same name now will only preserve the last one's value |
kevindb
reviewed
Jun 7, 2020
|
|
||
| if (options.data) { | ||
| var optionsData = $.isFunction(options.data) ? options.data(a) : options.data; | ||
| optionsData = $.isFunction(options.data) ? options.data(a) : options.data; |
There was a problem hiding this comment.
Why did you remove the var when declaring optionsData?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for post json body
Not enough time for adding unit test, @kevindb if you have time, you may add a few